feat:(APP-1055): Enable download of nested actions (10/10) - #1311
Open
milosh86 wants to merge 5 commits into
Open
feat:(APP-1055): Enable download of nested actions (10/10)#1311milosh86 wants to merge 5 commits into
milosh86 wants to merge 5 commits into
Conversation
milosh86
changed the base branch from
main
to
app-1032-implement-action-decodingdetails-view
August 7, 2026 14:51
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
milosh86
force-pushed
the
app-1055-enable-download-of-nested-actions
branch
from
August 10, 2026 09:01
ce80e71 to
eddcd7a
Compare
Signed-off-by: Milos Dzepina <milos@aragon.org>
milosh86
marked this pull request as ready for review
August 10, 2026 09:53
Signed-off-by: Milos Dzepina <milos@aragon.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes APP-1055.
Makes the "Download actions" export reusable and wires it into the two places that were still missing it: the standalone
ProposalActionsEditorand the read-only cross-chainforwardMessagedetails view.useDownloadProposalActions— extracted verbatim fromCreateProposalFormActionsintomodules/governance/hooks. Readsactionsfrom the surrounding form, runs the registered prepare functions(
proposalActionPreparationUtils.prepareActions, so actions needing async work such as IPFS pinning export theirfinal calldata) and downloads the result. Returns
{ isPinning, hasPinErrors, handleDownloadActions }.daoIdisoptional and only decides the file name (
dao-{daoId}-actions.json, elseactions.json), so the hook also worksoutside a DAO context.
CreateProposalFormActionsnow consumes that hook instead of holding the pinning state and download callback itself —no behaviour change.
ProposalActionsEditorgains the same download support, passingisPinning/hasPinErrors/onDownloadActionsthrough to
ActionComposer. Previously the button was only available in the create-proposal form.CrossChainControllerForwardMessageDetailsgets a "Download actions" button below the nested actions list, exportingthe raw
Action[]tuples decoded from the_messagepayload ascross-chain-{chainId}-actions.json. The button ishidden when the message holds no actions. This path does not go through
useDownloadProposalActions: the sub-actionsare already-encoded calldata read back from a published proposal, so there is nothing to prepare and no form context
to read from.
proposalActionsImportExportUtils—exportActionsToJSON/downloadActionsAsJSONnow acceptIExportableAction(Pick<IProposalAction, 'to' | 'value' | 'data'>) instead of the fullIProposalAction, which iswhat lets the raw cross-chain tuples be exported without being faked into proposal actions.
useDownloadProposalActions(prepare-then-download, file naming, error path), download coveragefor the cross-chain details view, and
createProposalFormActions.test.tsxnow spies onuseDownloadProposalActions(the component's actual dependency) rather than the form-provider context.
Dependencies: stacked on
app-1032-implement-action-decodingdetails-view→app-1054-…→app-1056-…→app-1053-…→
main. Merge the bases first. Last PR of the stack (10/10).Type of Change
Developer Checklist:
Review Checklist: